Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited message for DHCP #2945

Closed
wants to merge 1 commit into from
Closed

Edited message for DHCP #2945

wants to merge 1 commit into from

Conversation

LizenzFass78851
Copy link

@LizenzFass78851 LizenzFass78851 commented Feb 3, 2024

What does this PR aim to accomplish?:

Based on pr #2508 and the issues based on it pi-hole/pi-hole#3063, a line of text is changed in the settings.php to inform the user that if changes are made dhcp leases are made, which is mentioned in the new note, to restart the FTL for the changes to take effect.

  • I am aware that this change in v5 (which is just a text change) does not make sense since v6 will be released soon, but still I would like to use this PR to solve the problem mentioned above or complete the previous pull request mentioned above.

How does this PR accomplish the above?:

This pr simply appends a message in settings.php to inform users to run 'sudo service pihole-FTL restart' on their pihole if their devices are not issued the static IP address they have set.

Link documentation PRs if any are needed to support this PR:

I only added a simple text, so I don't think documentation is necessary.


By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.

  • I have read the above and my PR is ready for review. Check this box to confirm

Signed-off-by: LizenzFass78851 <[email protected]>

Co-authored-by: John Francis Sukamto <[email protected]>
@LizenzFass78851
Copy link
Author

Based on the statement from pi-hole/pi-hole#5471 (comment)

We are in the middle of our public Pi-hole v6.0 beta phase making it rather unlikely that there will be another regular v5.x Pi-hole release.

I now admit that it was unnecessary to create this pull request because no new v5 will be released and this may be contained or fixed in v6. Yes, it was too hasty from me to try this in such a short time.

@LizenzFass78851 LizenzFass78851 deleted the dhcp_message branch February 4, 2024 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant